Add OOB flow for VERIFY_AND_CHANGE_EMAIL - #7618
Merged
Merged
Conversation
aalej
approved these changes
Sep 4, 2024
aalej
left a comment
aalej
left a comment
Contributor
There was a problem hiding this comment.
This LGTM! Thanks for submitting a PR! Tested using https://github.com/aalej/pull-7618/tree/main and it looks like the behavior in the emulator matches the one in prod. @joehan, this looks like a new feature, we might need to find someone from Auth team to review this as well.
joehan
enabled auto-merge (squash)
September 10, 2024 05:16
joehan
disabled auto-merge
September 10, 2024 15:55
tammam-g
pushed a commit
that referenced
this pull request
Sep 13, 2024
Co-authored-by: joehan <joehanley@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement
VERIFY_AND_CHANGE_EMAILOOB flow toaccounts:sendOobCodeAPI in Firebase Emulator. This changes allows you to useverifyBeforeUpdateEmailin Firebase Javascript SDK,generateVerifyAndChangeEmailLinkin Firebase Admin SDK andaccounts:sendOobCodeAPI with requestTypeVERIFY_AND_CHANGE_EMAILas well.Refs #3424
Scenarios Tested
verifyAndChangeEmailmode by accessing the URL returned fromgenerateVerifyAndChangeEmailLinkcheckActionCodeandapplyActionCodeoffirebase/auth