feat: support custom webpack and ngx-env builders - #7557
Merged
Merged
Conversation
9kubczas4
marked this pull request as ready for review
August 20, 2024 15:38
9kubczas4
changed the title
| LEGACY_DEVKIT_SSR_DEV_SERVER = "@angular-devkit/build-angular:ssr-dev-server", | ||
| } | ||
|
|
||
| const enum ThirdPartyBuilder { |
Contributor
There was a problem hiding this comment.
Qq, could we just simplify all this and only look after the last colon and expect it to conform to the builder-type? e.g, ":application", ":dev-server", ":server", ":browser", etc.
Contributor
There was a problem hiding this comment.
@jamesdaniels Regarding to this PR, I created another one with the requested changes:
#8256
* Added handling for different angular builders * Remove unused method from angular * Review changes, tests and cleaning * Removing empty jsdocs * Fixing tests * Update src/frameworks/angular/utils.ts --------- Co-authored-by: Leonardo Ortiz <leo@monogram.io>
jamesdaniels
approved these changes
Mar 12, 2025
jamesdaniels
left a comment
jamesdaniels
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for taking to the finish line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR supports the custom Angular builders requested in the following issues:
Scenarios Tested
Deployed Angular applications which uses following builders:
Sample Commands