Skip to content

Fix functions:secrets:set - stop erroring in non-interactive flows without force option - #7467

Merged
colerogers merged 8 commits into
masterfrom
colerogers.fix-secrets-interactive-mode
Jul 30, 2024
Merged

Fix functions:secrets:set - stop erroring in non-interactive flows without force option#7467
colerogers merged 8 commits into
masterfrom
colerogers.fix-secrets-interactive-mode

Conversation

@colerogers

@colerogers colerogers commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #7466

@colerogers colerogers changed the title Adding error for non-interactive flows without force option Fix functions:secrets:set - add error for non-interactive flows without force option Jul 18, 2024
@colerogers
colerogers requested review from aalej and taeold July 18, 2024 19:58
@ytetsuro

ytetsuro commented Jul 22, 2024

Copy link
Copy Markdown

@colerogers

Thank you.
If this PR is merge, it would be difficult to overwrite the secret manager value and terminate successfully without running redeploy.
Am I correct in my understanding?
I would rather not redeploy as I want to deploy stably.

joehan
joehan reviewed Jul 23, 2024
View reviewed changes
Comment thread src/commands/functions-secrets-set.ts Outdated
@colerogers colerogers changed the title Fix functions:secrets:set - add error for non-interactive flows without force option Fix functions:secrets:set - stop erroring in the non-interactive flows without force option Jul 30, 2024
@colerogers colerogers changed the title Fix functions:secrets:set - stop erroring in the non-interactive flows without force option Fix functions:secrets:set - stop erroring in non-interactive flows without force option Jul 30, 2024
@colerogers
colerogers enabled auto-merge (squash) July 30, 2024 19:14
@colerogers

colerogers commented Jul 30, 2024

Copy link
Copy Markdown
Contributor Author

@ytetsuro I think I understand the issue better, our behavior for running functions:secrets:set with responding no to the prompt was different than running functions:secrets:set --non-interactive. The latter was producing an error that the former was not. This PR should now fix that.

@colerogers
colerogers merged commit 68be9c5 into master Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joehan joehan joehan approved these changes
@taeold taeold Awaiting requested review from taeold
@aalej aalej Awaiting requested review from aalej

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(Functions)The redeploy option is undefined, but an error message is displayed asking to use the redeploy option.

3 participants

@colerogers @ytetsuro @joehan