Upgrade typescript version to v6 in templates - #10232
Conversation
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request attempts to update the TypeScript dependency to version 6.0.0 across several template configuration files. However, TypeScript 6.0.0 has not been released yet, and using this version will cause dependency installation failures. The reviewer has correctly identified this issue and suggested reverting to the current stable version, 5.7.3. Additionally, the pull request lacks the required description sections and a CHANGELOG.md entry as specified in the repository style guide.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
106a0b3 to
db5578f
Compare
|
Hi @joehan, friendly ping on this :) let me know if there is a better reviewer. |
|
LGTM, just add a changelog entry |
Keeping typescript code here up-to-date.
Keeping typescript version up-to-date. Includes defining the rootDir to src in tsconfig.json.
b3d5615 to
4ea78f0
Compare
3 participants
Description
Upgrade typescript version to 6.0 following https://devblogs.microsoft.com/typescript/announcing-typescript-6-0/.
Scenarios Tested
First ran in firebase-tools root.
Then, followed up with making a clean directory and executing the following commands in the functions dir after
firebase init functions.