Closed Bug 2004273 Opened 10 months ago Closed 24 days ago

Turn devtools/client/jsonview/converter-child.js into an ES class

Categories

(DevTools :: General, task, P3)

Product:
DevTools
Component:
General
Type:
task

Tracking

(firefox157 fixed)

Status:
RESOLVED FIXED
Milestone:
157 Branch
Tracking Flags:
Tracking Status
firefox157 --- fixed

People

(Reporter: nchevobbe, Assigned: sfshah)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files, 1 obsolete file)

Bug 2004273: Convert converter-child.js to ES class r=nchevobbe
48 bytes, text/x-phabricator-request
Details | Review
Bug 2004273 - Turn devtools/client/jsonview/converter-child.js into an ES class r?nchevobbe!
48 bytes, text/x-phabricator-request
Details | Review
Severity: -- → S3
Priority: -- → P3

I’d like to work on this bug. Could you please assign it to me?

(In reply to Vignesh Sadankae from comment #1)

I’d like to work on this bug. Could you please assign it to me?

sure, it's yours now :)

Assignee: nobody → sadanki190
Status: NEW → ASSIGNED
Attachment #9531313 - Attachment description: WIP: Bug 2004273: Convert converter-child.js to ES class → Bug 2004273: Convert converter-child.js to ES class
Attachment #9531313 - Attachment description: Bug 2004273: Convert converter-child.js to ES class → Bug 2004273: Convert converter-child.js to ES class r=nchevobbe

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Assignee: sadanki190 → nobody
Status: ASSIGNED → NEW

@nchevobbe please assin me this bug , i have started investigation

Flags: needinfo?(nchevobbe)

(In reply to karan68 from comment #5)

@nchevobbe please assin me this bug , i have started investigation

done, thank you :)

Assignee: nobody → mekaranyadav8
Status: NEW → ASSIGNED
Flags: needinfo?(nchevobbe)

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Assignee: mekaranyadav8 → nobody
Status: ASSIGNED → NEW

Hey, I'd like to work on patching this

I've got a WIP patch on phabricator; any recommended tests I should run?

Flags: needinfo?(nchevobbe)
Assignee: nobody → sfshah
Status: NEW → ASSIGNED
Attachment #9634007 - Attachment is obsolete: true
Attachment #9636714 - Attachment description: just-copied Bug 2004273 - Turn devtools/client/jsonview/converter-child.js into an ES class r?nchevobbe! → Bug 2004273 - Turn devtools/client/jsonview/converter-child.js into an ES class r?nchevobbe!

(In reply to sfshah from comment #10)

I've got a WIP patch on phabricator; any recommended tests I should run?

sorry for the delay, I'm just back from PTO
you can run all the test in the json viewer folder, it shouldn't take too long: ./mach test devtools/client/jsonview/test/

Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/88ebb3424b57 https://hg.mozilla.org/integration/autoland/rev/3d6daec24655 Turn devtools/client/jsonview/converter-child.js into an ES class r=nchevobbe,devtools-reviewers

https://hg.mozilla.org/mozilla-central/rev/3d6daec24655

Status: ASSIGNED → RESOLVED
Closed: 24 days ago
status-firefox157: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
QA Whiteboard: [qa-triage-done-c158/b157]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: